[MERGE] test framework distinguishes skips

Aaron Bentley aaron.bentley at utoronto.ca
Tue Jul 11 06:58:22 BST 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> On 10 Jul 2006, Aaron Bentley <aaron.bentley at utoronto.ca> wrote:
>> John Arbash Meinel wrote:
>> Thanks for the +1.  I won't commit it immediately unless I get another +1.
> 
> Robert raised some concerns on IRC so let's hold off on this for the
> moment.  

Certainly.

> I wonder if we could remove the other uses of decorators - just
> let all of the dependency missing things propagate up and report on them
> directly?

The other use of decorators is the fails_with decorator.  That one could
be altered so that on standard TestRunners it returns, but on our
TestRunner, it raises ExpectedFailure.  If you use a plain-old function,
you have to return it:

def test_thing_that_fails(self):
    try:
       thing_that_fails()
    except MyFailure e:
       return self.expectedFailure(e)
    else:
       self.unexpectedSuccess()

> Do you have a URL for that branch so I can look at where we finally got
> up to?

Sure:
http://code.aaronbentley.com/bzr/bzrrepo/testframework/

> I've added some thoughts at the bottom of this
> 
>   http://bazaar-vcs.org/BzrExtendTestSuite

Cool, I'll have a look.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEsz3+0F+nu1YWqI0RAgK6AKCH2gltFq5NeBoqaTToFRE/ISBAAgCfQQHN
lPKIQjB9QnnvvVlSRvhaKYY=
=S4NV
-----END PGP SIGNATURE-----




More information about the bazaar mailing list