[patch] 'bzr mv' with no arguments breaks
John Arbash Meinel
john at arbash-meinel.com
Tue Jul 11 04:34:43 BST 2006
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Wouter van Heyst wrote:
> On Sat, Jul 08, 2006 at 10:38:38AM -0500, John Arbash Meinel wrote:
...
> I had a brief look at WorkingTree.move, and apart from using %r, there
> are several BzrErrors that aren't tested for. I'd like to come back to
> those soon, but not right now for this unqualified mv.
>
> ...
>
>> If you want to test 'rename' and 'move' as aliases of 'mv'. That's fine,
>> but it should be done in a single test function, not randomly throughout
>> the other tests. (And I do realize that this is just because you are
>> cleaning up the ugly ugly OldTests.)
>
> Added a smoketest for 'rename' and 'move'.
>
...
>
> I don't mind the practice of the review process, but it would be nice to
> get this done and out of the way. The attached patch isn't perfect (some
> redundancy bothers me for instance), but is it good enough for now?
>
> Wouter van Heyst
>
Thanks for all your cleanup work. The mv tests look a lot better. +1
from me.
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFEsxxTJdeBCYSNAAMRAkgeAKCXyKGKTOQ0WatLPrMCtN9haSYxsgCeNC7w
jcyUi5gbMQzpku7VWIfB1Dw=
=l1rn
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list