[MERGE] push handles file-ids containing quotes correctly

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
> John Arbash Meinel wrote:
> 
>>> I just want a test that if something is wrong, we will fail noisily
>>> rather than silently. If you can do it at a higher level, feel free.
>>>
>>> Otherwise, you have my +1.
> 
> Done, since you insist.  I still think it's pointless to test the
> unescaper, since if the XML text is not a valid inventory, (even if it's
> well-formed XML) file_ids_affected_by is probably broken.
> 
> Aaron

Well, it may be valid escaped XML. We obviously missed ', so it
seem possible that we are missing others. Which we won't find until a
bug surfaces again. And I'd rather it surface early rather than later.

I don't know of anything we are missing. But I know that as of right
now, we don't have a lot of testing for extended unicode file ids. We
claim to support them, but bzr doesn't have a way of generating them
itself (gen_file_id() squashes non-ascii chars). And we kind of continue
that, because it plays nicer on all filesystems. But theoretically there
could be bugs in an extended character set that we just haven't come
across yet.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEsrvqJdeBCYSNAAMRAj6yAKDPJdsGzaXGPvS50vXh4+35A337mwCgjkXc
6Yi051m/yhJSAvG2/V7S1LU=
=kODp
-----END PGP SIGNATURE-----