[MERGE] push handles file-ids containing quotes correctly

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
> Here's a version I hope we can agree on.
> 
> Aaron

The only thing I would like to add is a test of _unescape_xml that tests
that it will fail noisily if given a &; string that it doesn't understand.
A simple:

self.assertRaises(KeyError, _unescape_xml, 'foo&bar;')

Is sufficient. I don't think there is any way to create a file_id which
would be invalid that we can pass in (I suppose we could much the knit
text itself, but I don't really like doing that).

I just want a test that if something is wrong, we will fail noisily
rather than silently. If you can do it at a higher level, feel free.

Otherwise, you have my +1.

John
=:->



-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEsrSrJdeBCYSNAAMRAinAAKCFItOF03fEmAbPaXcPLXeODyvxzgCgpFsb
K10iZlZlVkiDenmuhkZTU0Y=
=ZZs2
-----END PGP SIGNATURE-----