bzr selftest failure (bundles ?)

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Matthieu Moy wrote:
> John Arbash Meinel <john at arbash-meinel.com> writes:
> 
>> That's exactly what was happening. The attached bundle should fix the
>> problem for you.
>>
>> Basically, the bug was just that we weren't taking the minute portion *60.
> 
> Yes, this is purely a timezone problem. One tzconfig to Paris time and
> the test succeed.
> 
>> But I updated the doctests (and it did fail), so I'm pretty sure I got
>> it right this time.
> 
> Some tests still fail.
> 
> I'm putting the new test report here (but I suppose you can reproduce
> the bug if you have priviledge to run tzconfig on your machine):
> 
>   http://www-verimag.imag.fr/~moy/tmp/selftest-results.txt
> 

Looking into it further, I found the problem. In the upgrade from a
plugin to a builtin, there was some code that was copied into a new
file, but the old file wasn't removed. So we actually had 2 copies of
format_highres_date and unpack_highres_date, I fixed one, and that was
used by some code, but the other one was used by other code.

So I've cleaned it up.

I went ahead and added a test of bundles that includes TZ offset of
0530. (19800 seconds).

- From the current discussion, I wouldn't normally add a bundle test, for
a bug in unpack_highres_date, but since the second bug was Bundle's
using the wrong function, I think the test is merited.

I'll actually post the merge request in another email.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEsnTPJdeBCYSNAAMRAkzEAJ4x13lp4AJeyNTAKlorlLIm6s+OagCfWH2R
OWL6s+EWc/uMP60r/Sb0D70=
=7zT6
-----END PGP SIGNATURE-----