Garbage in "bzr commit" output

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> Aaron Bentley wrote:

>>>This is fine, but it doesn't fix Moy's problem, because he doesn't want
>>>progress bars displayed at all.
> 
> 
> His specific problem is that commit is still throwing garbage, even
> though there is no progress bar showing up.
> 
> It isn't a 100% fix, because we still need a way to completely disable
> progress bars. But it fixes the short-term.

There are lots of operations that produce progress bars -- even commit
on a large tree will do this.  So even in the short term, he's likely to
get progress bars where he doesn't expect them.  The garbage is just a
symptom of the fact that tty progress bars are still active.

>>>We could actually just store the start time and the number of updates,
>>>couldn't we?

> It depends what kind of ETA you want to produce. There are several ways
> of computing it, and the current method is probably slightly more accurate.
...
> It may not be worth the complexity, though.

I'm okay with it, if there's a reason for it.  I just looked at the code
and thought "whoah, I must have been really lazy when I wrote that."
But I wasn't looking closely enough.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFErsNx0F+nu1YWqI0RAtfeAJ4wsnvedwSn2jy1L6Ic7CVLKP2l/ACeMRpv
s7OiiXe/L3oRML059WUiQRY=
=8+Cy
-----END PGP SIGNATURE-----