[BUNDLE] Allow different diff output

[John Arbash Meinel]

Szilveszter Farkas wrote:
> hi,
> 
> this is my first change to the bzr.dev codebase, maybe i did some
> things wrong. please correct me :)
> 
> i attached a bundle which makes a trivial change: it allows the diff
> output to be sent to other (file)streams than sys.stdout.
> 
> this little modification makes my life easier regarding the gui
> development :)
> 
> regards,
> szilveszter / phanatic

Well, to start with, we commonly name the bundle *.patch or .diff or
.txt so that we can read it as part of the email. :)

It does mean there is a higher chance of corruption by email programs,
but it makes reviews much easier.


I think it is better to do:

def diff_cmd_helper(..., output=None):

  if output is None:
    output = sys.stdout


But more importantly, is there a reason why 'show_diff_trees' is not
sufficient for you?
diff_cmd_helper doesn't seem to provide a whole lot on top of that.
But I'm not opposed to updating the diff_cmd_helper api.

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060706/45f633d0/attachment.pgp