nits about get_revisions...

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> OK, docstrings definitely should be reviewed.

Yes, I agree.  I think did put some effor into docstrings for that
merge, but this really visible one is no good.

> On the other - I'm all in favour of consistently formatted code, but
> having zero or one or two lines of whitespace in particular places is
> fairly far down my priority list, to the extent that I'd rather just fix
> it later than make people iterate their submission.

I think we're tending to say "+1 if you fix that" for that level of
thing.  That way, there doesn't need to be a list round trip, but the
code does get fixed (just) before it gets merged.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFErJ/00F+nu1YWqI0RAk9AAKCJMHPbDIDBiizVfBn5rxrZlKPYQQCeMNcZ
i8w0Bx5bovOZwBwhM0FE5Vg=
=uUwG
-----END PGP SIGNATURE-----