test_nonascii: two unicode a's

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> Aaron Bentley wrote:
>>> Well, if typical implementations of diff3 on win32 are broken, I think
>>> we should not permit merge-type diff3 on that platform at all.  The test
>>> failure indicates that, on win32, --merge-type diff3 really is broken.

> I agree with you. And I can also say that my cygwin implementation of
> diff3 actually is doing the right thing. (The tests pass on my system).
> 
> I'm not 100% comfortable with skipping tests just because they might
> fail, especially because of external factors (whether OS or an external
> program).
> 
> Using 'bzr merge --merge-type=diff3' will potentially do bad things on
> Alexander's system. It seems like he should be made aware of that, by
> something like a test failure.

I was actually suggesting preventing diff3 from being used on win32 at
all.  Because the number of win32 users who are likely to have a sane
version of diff3 is small, and I think "merge-type diff3" is a pretty
rarely-used option.

> I'm wondering about augmenting the test suite with some sort of
> more-helpful summary. So you run the test suite, and at the end you get:
> 
> failures = 0, errors = 0, limitations = 4
> Platform Limitations:
>    diff3 does not preserve line endings, exercise caution with
> --merge-type=diff3. Or install a diff3 which preserves line endings.

I think that sort of thing would be nice, in general.

> I don't know exactly the implementation or final output. But just
> skipping tests because we want to have the test suite pass seems unclean
> to me.
> Essentially, you are lying to the user, telling them that there are no
> problems, rather than actually telling them what limitations are present.

Now I feel like we've swapped positions from a couple days ago.  I don't
consider skipping tests to be saying there are no problems.  And I've
seen people whose reaction on seeing "x test(s) skipped" is "Okay, what
do I have to do to make them run"?

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEqv4M0F+nu1YWqI0RApj1AJ0ZuoefjbpecTYDwbf29byMa3n7EACfQ+k5
scJGoEj+VjkXNswMb0SlEnE=
=WmK9
-----END PGP SIGNATURE-----