win32: selftest result after merge John win32 fixes

[Alexander Belchenko]

It's very strange for me, but after merging John's work into mainline 
amount of failed tests increased (was 19, now 27). And during selftest 
there is error message on the screen:

running tests...
bzr: ERROR: [Errno 13] Permission denied: 
u'E:/work/MyCode/bzr/devel/bzr.dev/test0000.tmp\\_reconcile.TestsNeedingReweave
.test_reweave_inventory_without_revision_reconciler(RepositoryFormat7)'

And again testXXXX.tmp directory won't delete after selftest.

New tests with problems:

...TestsNeedingReweave.test_convenience_reconcile_inventory_without_revision_reconcile(RepositoryFormat7)ERROR 
         405ms
...ry_implementations.test_reconcile.TestsNeedingReweave.test_reconcile_empty_thorough(RepositoryFormat7)ERROR 
         297ms
repository_implementations.test_reconcile.TestsNeedingReweave.test_reconile_empty(RepositoryFormat7) 
     ERROR         280ms
...oncile.TestsNeedingReweave.test_reweave_inventory_fixes_ancestryfor_a_present_ghost(RepositoryFormat7)ERROR 
         296ms
...concile.TestsNeedingReweave.test_reweave_inventory_preserves_a_revision_with_ghosts(RepositoryFormat7)ERROR 
         296ms
...ntations.test_reconcile.TestsNeedingReweave.test_reweave_inventory_without_revision(RepositoryFormat7)ERROR 
         312ms
...reconcile.TestsNeedingReweave.test_reweave_inventory_without_revision_and_ghost(RepositoryFormatKnit1)ERROR 
         858ms
...econcile.TestsNeedingReweave.test_reweave_inventory_without_revision_reconciler(RepositoryFormatKnit1)ERROR 
         781ms

Before there is also similar failed tests:

...est_reconcile.TestsNeedingReweave.test_reweave_inventory_without_revision_and_ghost(RepositoryFormat7)ERROR 
         297ms
...st_reconcile.TestsNeedingReweave.test_reweave_inventory_without_revision_reconciler(RepositoryFormat7)ERROR 
         296ms

All this failed tests (with error) have identical problem. In test.log I 
see this traceback:

Traceback (most recent call last):
   File 
"E:\work\MyCode\bzr\devel\bzr.dev\bzrlib\tests\repository_implementations\test_reconcile.py", 
line 195, in test_reweave_inventory_without_revision_and_ghost
     thorough=True)
   File 
"E:\work\MyCode\bzr\devel\bzr.dev\bzrlib\tests\repository_implementations\test_reconcile.py", 
line 157, in check_thorough_reweave_missing_revision
     reconciler = reconcile(**kwargs)
   File "E:\work\MyCode\bzr\devel\bzr.dev\bzrlib\decorators.py", line 
51, in write_locked
     return unbound(self, *args, **kwargs)
   File "E:\work\MyCode\bzr\devel\bzr.dev\bzrlib\repository.py", line 
945, in reconcile
     reconciler.reconcile()
   File "E:\work\MyCode\bzr\devel\bzr.dev\bzrlib\reconcile.py", line 
108, in reconcile
     self._reconcile_steps()
   File "E:\work\MyCode\bzr\devel\bzr.dev\bzrlib\reconcile.py", line 
280, in _reconcile_steps
     self._gc_inventory()
   File "E:\work\MyCode\bzr\devel\bzr.dev\bzrlib\reconcile.py", line 
323, in _gc_inventory
     self.repo.control_weaves.copy(new_inventory_vf, 'inventory', 
self.transaction)
   File 
"E:\work\MyCode\bzr\devel\bzr.dev\bzrlib\store\versioned\__init__.py", 
line 248, in copy
     source.copy_to(self.filename(result_id), self._transport)
   File "E:\work\MyCode\bzr\devel\bzr.dev\bzrlib\knit.py", line 395, in 
copy_to
     transport.put(name + DATA_SUFFIX, f)
   File "E:\work\MyCode\bzr\devel\bzr.dev\bzrlib\transport\local.py", 
line 145, in put
     fp.commit()
   File "E:\work\MyCode\bzr\devel\bzr.dev\bzrlib\atomicfile.py", line 
78, in commit
     rename(self.tmpfilename, self.realfilename)
   File "E:\work\MyCode\bzr\devel\bzr.dev\bzrlib\osutils.py", line 265, 
in _win32_rename
     fancy_rename(old, new, rename_func=os.rename, unlink_func=os.unlink)
   File "E:\work\MyCode\bzr\devel\bzr.dev\bzrlib\osutils.py", line 190, 
in fancy_rename
     rename_func(old, new)
OSError: [Errno 17] File exists


Is this again issue with u'\xe4' vs u'\xe5' on my FAT32?

--
Alexander