[merge] follow up, fix the rest of the mac tests
John Arbash Meinel
john at arbash-meinel.com
Mon Jul 3 19:48:02 BST 2006
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
John Arbash Meinel wrote:
> I took some time today to work through some of the unicode normalization
> issues on Mac OS-X.
> As a quick summary, Mac doesn't preserve filenames if they use non-ascii
> names, instead choosing to always normalize them. Unfortunately, they
> chose a bad normalization.
> This patch modifies WorkingTree.list_files() and .extras() so that after
> listing a directory, if a file isn't found, it then attempts to
> normalize the filename, and try again.
> It also modifies Inventory.make_entry() so that we won't create
> non-normalized inventory entries.
>
I went ahead and fixed up the rest of the mac tests. It turned out the
only thing left was to write a new getcwd() for Mac, which returns the
normalized path. And then track down WorkingTree, since it was directly
calling os.getcwdu() instead of osutils.getcwd().
Anyway, combining the previous patch with this patch means all tests
pass on Mac.
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFEqWZiJdeBCYSNAAMRAt2jAKCmXOotDntL55FVpFt3IR//sviGigCcD2Cj
iAk8E9D4bNt94qPdKC51BkQ=
=eYJy
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: mac-getcwd-cleanup.diff
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20060703/555cf1fa/attachment.diff
More information about the bazaar
mailing list