[MERGE] init remote branches
John Arbash Meinel
john at arbash-meinel.com
Mon Jul 3 02:23:48 BST 2006
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Aaron Bentley wrote:
> John Arbash Meinel wrote:
>>> With our os-specific functions (like getcwd()) if we only import the
>>> osutils module, then we can actually hijack the specific implementation
>>> in the test suite, to make sure that the rest of the codebase does the
>>> right thing.
>
> I don't understand this. It sounds like you're talking about directly
> invoking osutils.get_cwd, or os.get_cwd, and I agree that when you want
> to use both, it often makes sense to use the module name to distinguish
> functions. But that doesn't sound like 'hijacking' to me, so I must be
> missing something.
>
> Aaron
I'm actually talking about hijacking stuff like 'osutils.getcwd()'
inside of the test suite.
Specifically, I'm hijacking a new function called
"osutils.normalized_filename" which is handling the unicode
normalization stuff.
What I want to test is that creating an inventory entry succeeds/fails
based on what normalized_filename returns. Usually what it returns
depends on the platform, but I'm forcing it so that I can test
inventory.make_entry() regardless of what platform I'm on.
Yes, it is hijacking, but the more cross-platform tests we can run under
linux, the more we will stop breaking other platforms.
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFEqHGkJdeBCYSNAAMRAt4CAKDDFZY4Dru/k3tZIWKLn5E5N0X4lwCfWs6p
iXFH9UMv2Om09OLEhwMIG9I=
=2GCT
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list