[merge] win32- fix test_bundle

John Arbash Meinel john at arbash-meinel.com
Sun Jul 2 05:06:59 BST 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
> John Arbash Meinel wrote:
>>> Hopefully this is my last win32 related bugfix for a while. And it
>>> should be, since the test suite now passes :)
>>>
>>> Anyway, I updated the test suite to use a starting space, rather than a
>>> trailing space. Which is supported on win32.
> 
> I thought that it made a lot of sense to be testing for trailing spaces.
>  That's the kind of area where bundles are most vulnerable.
> 
> I'd prefer to move this and the tab test into a different test, and skip
> it on Win32.

So, this found that '\t' is not supported, so I'm not doing this (yet).
Otherwise I did create a new whitespace test, which tests all 4
operations (add/rename/modify/delete).

I also did 1 better, and factored out the internationalization tests.
It turns out Erik wasn't the original unicode man. It was actually
Willam Dodé. :)
I think Erik was the first to actually get a commit into bzr.dev (which
started breaking stuff, and forcing the rest of us to cope).

But William is the one who got his name into my changeset plugin. The
lines with his name were added in 2005-07-16.

I could be wrong. According to my email archive, both people were active
in bzr last June. But I think Dodé would have been the first with his
name in a source file.

Though then again, since my changeset work wasn't merged into mainline
until recently, Erik still gets to claim being the first to have his
name in the bzr.dev tree.


> I'd like to switch the order of the trees.  When I examined the delta
> here, it said 'file with trailing space added', which was confusing
> because that path was actually missing from the working tree.

Done.

> 
> Aaron

How's the attached patch?

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEp0ZiJdeBCYSNAAMRAoGOAJ9qo2mGa2+hbrLfOb3kIvV4t+rurACeNnPZ
iDvL+sGypvh0KqduwQ94QSw=
=Cyc3
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: win32-restore-whitespace-bundle.diff
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20060701/97b73c99/attachment.diff 


More information about the bazaar mailing list