[BUG] 'bzr update' always says 'Updated to revision'

John Arbash Meinel john at arbash-meinel.com
Sun Jul 2 03:09:19 BST 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

If you have a bound branch, running 'bzr update' reports:
	Updated to revision 1817.

Even if nothing has changed. This is different from the case when you
are in an unbound branch, and it reports:
	Tree is up to date.

I would actually prefer it if both of them reported:

	Tree is already up to date at revision 1817.

Looking at the code, the first part is just a simple bug. We have this:

if master is None or master.last_revision == tree.last_revision():
Which should be:
if master is None or master.last_revision() == tree.last_revision():

Just missing the (). So we were comparing a function object to a string.

The attached patch changes the code to print out the revision number
even if the tree is up to date, and fixes the bug about not printing
up-to-date in a bound branch.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEpyrPJdeBCYSNAAMRAooiAKDCPB/bV458VlIFY+zcsTqRB0n8XgCg1UBK
vkYElkoCxdNdeXsUyJ4FzcE=
=nu1x
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-update-when-bound.patch
Type: text/x-patch
Size: 3024 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060701/06d18474/attachment.bin 


More information about the bazaar mailing list