win32: windows strip off last space from filename
John Arbash Meinel
john at arbash-meinel.com
Sat Jul 1 22:27:19 BST 2006
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Alexander Belchenko wrote:
> I have windows 2000 on FAT32. The same behaviour with cygwin on the same
> FS.
>
>>>> import os
>>>> os.listdir('.')
> []
>>>> f = file('with space at end ', 'wb')
>>>> f.write('spam')
>>>> f.close()
>>>> f
> <closed file 'with space at end ', mode 'wb' at 0x009144E8>
>>>> os.listdir('.')
> ['with space at end']
...
>
> I was check this behaviour with simple C program. The same result.
>
> To John, Aaron: that's why test_bundle fails on win32.
>
> --
> Alexander
Actually, I came across this in the past, but didn't think too much of
it. Thanks for pointing it out. I'll just change the test for now. It
was originally meant to test whether we properly handled trailing
whitespace since it would be tempting to just 'strip()' it as part of
bundle processing.
I don't think people are commonly creating files with trailing
whitespace anyway, so I'll just remove the file from the test suite.
So after this fix, the test suite should pass on win32. Is it passing
for you Alexander?
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFEpui3JdeBCYSNAAMRApvPAKDHqQ9JtK5VriCs1+VpMIBjCMP9+wCgqZrf
/lpOzVqb+dXXzOicL2atG0I=
=3zkR
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list