[MERGE] bundle commandline cleanup

Aaron Bentley aaron.bentley at utoronto.ca
Thu Jun 29 16:11:51 BST 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
>>>Doesn't that mean it will go to stdout, not stderr?
> 
> 
> You're right. You could instead do:
> 
> encoding = osutils.get_terminal_encoding()
> encoded_url = urlutils.urlfordisplay(base, encoding).encode(encoding)
> sys.stderr.write('Using saved location: %s\n' % (encoded_url,))

> But you are right, we should send it to stderr, not stdout. We probably
> should fix up the other occurrences, and turn this into a fully fledged
> helper function.

I'm happy to tweak the string for the URL, but I don't understand why we
would want to replace note with a new helper.  My idea of note is that
it doesn't necessarily output to stderr, just to a secondary channel.
In a GUI app, that might be a status bar, for example.

ProgressBar also has a note() function attached to it, because Robert
wanted to be able to associate specific notes with with the progress
they're annotating.

> Okay, I guess I didn't catch that part. I thought this had been merged,
> and was disappointed when I tried to use it, and it failed again. :)

I'll do the urlutils and last_revision fixes, but I'd like to leave
note() as is until we've cleared up what to do about it.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFEo+230F+nu1YWqI0RAjO7AJ9GjU25Y1mo0ThzWyP7LBa7SNLiygCgiM3Q
164OJ7Kz1zNcgkO27UXwMYw=
=+Fg6
-----END PGP SIGNATURE-----




More information about the bazaar mailing list