[MERGE] bundle commandline cleanup

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John A Meinel wrote:
> +            elif not base_specified:
> +                note('Using saved location: %s' % base)
> +            base_branch = Branch.open(base)
> 
> 
> ^- this should be:
> 
> self.outf.write('Using saved location: %s\n'
> 	% urlutils.urlfordisplay(base, self.outf.encoding))

Doesn't that mean it will go to stdout, not stderr?

> ^- So why are you always pulling from 'last_revision()' rather than the
> base revision that was specified? Potentially they are not even the same
> ancestry.
> It is possible the user did:
> 
> bzr bundle -r revid:...
> And that isn't related to the last_revision()

I guess I'm set in my ways.  I'll look at fixing that.

> v- I don't see anything in these tests that check the output of
> 'run_bzr' to make sure it isn't printing 'used saved location' twice.

This is the bit that makes sure it only prints it once:
> +        self.assertEqual(stderr.count('Using saved location'), 1)

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFEo+g60F+nu1YWqI0RAn6uAJ9NTvU6N81N2m9QntGfFaXlzK1ZIwCeORxO
V506vth99rJ7H7S0Vhpj2VQ=
=sFpx
-----END PGP SIGNATURE-----