[merge] catching EPIPE (especially on win32)

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> Aaron Bentley wrote:
>>> Perhaps we should rethrow it as SilentKeyboardInterrupt or
>>> PrettyKeyboardInterrupt, but the default handling of KeyboardInterrupt
>>> is dead ugly, and I don't think we want to use that.

> Is this because originally we didn't handle KeyboardInterrupt properly?

It was also the text 'KeyboardIterrupt'.

> I think we have it handled in a reasonable way. Otherwise I would agree
> with you that printing a traceback just because someone hit ^C in the
> middle is a bit ugly.

So I think we have a difference of opinion about whether we should print
errors when the user deliberately terminates a display command.  It's
not about whether display_command should swallow KeyboardInterrupt, it's
about whether display_command is appropriate to use at all.  (Because,
as you say, pipe errors are already special-cased.)

I think that it does not make sense to print error messages when there's
no error, that it looks nicer if we don't.  Also, the fewer error
messages we emit, the more people will pay attention when we do emit one.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEo08L0F+nu1YWqI0RAiVIAJ4gpgBApd4qeWxjfSS3E68JGeqfzgCeIsnV
tN75yGy/IM0jeRkRwvf2OWY=
=pJYi
-----END PGP SIGNATURE-----