[BUG] bzr 0.8 add on Unicode filename fails

[John Whitley]

>> John A Meinel wrote:
>>> I have a branch which has done a lot of the work, available here:
>>> http://bzr.arbash-meinel.com/branches/bzr/encoding/

I'm still seeing this issue (reported as [1]) on Cygwin with bzr.dev  
revno 1816.  bzr add does work correctly on Mac OS X now (modulo the  
unicode normalization issues cited by John previously).  The  
exception trace is included below.

-- John

[1] https://launchpad.net/products/bzr/+bug/43689

------- exception follows -------

bzr: ERROR: exceptions.UnicodeDecodeError: 'ascii' codec can't decode  
byte 0xca in position 5: ordinal not in range(128)

Traceback (most recent call last):
   File "/home/jwhitley/src/bzr/no-knit-cache/bzrlib/commands.py",  
line 692, in run_bzr_catch_errors
     return run_bzr(argv)
   File "/home/jwhitley/src/bzr/no-knit-cache/bzrlib/commands.py",  
line 655, in run_bzr
     ret = run(*run_argv)
   File "/home/jwhitley/src/bzr/no-knit-cache/bzrlib/commands.py",  
line 281, in run_argv_aliases
     return self.run(**all_cmd_args)
   File "/home/jwhitley/src/bzr/no-knit-cache/bzrlib/builtins.py",  
line 276, in run
     action=action, save=not dry_run)
   File "/home/jwhitley/src/bzr/no-knit-cache/bzrlib/add.py", line  
104, in smart_add
     return smart_add_tree(tree, file_list, recurse, action=action)
   File "/home/jwhitley/src/bzr/no-knit-cache/bzrlib/add.py", line  
252, in smart_add_tree
     subp = bzrlib.osutils.pathjoin(directory.raw_path, subf)
   File "/tmp/python.340/usr/lib/python2.4/posixpath.py", line 65, in  
join
     path += '/' + b
UnicodeDecodeError: 'ascii' codec can't decode byte 0xca in position  
5: ordinal not in range(128)

bzr 0.9.0dev0 on python 2.4.3.final.0 (cygwin)
arguments: ['/home/jwhitley/local/bin/bzr', 'add']