[MERGE] Factor out revision-history synthesis for reuse

[Robert Collins]

On Tue, 2006-06-20 at 12:17 -0500, John Arbash Meinel wrote:
> Robert Collins wrote:
> > I had a case where I need to create a new revision-history recently.
> > This patch made it easier:
> > 
> > Cheers,
> > Rob
> > 
> > 
> 
> +1 from me. But should this be part of BzrBranch, or part of Repository.
>  Repository has all the information it needs, so it seems the right
> place to put it.

Well, no. Yes, *part* of it can be moved to repository, but not the
whole thing, and I'm fairly sure that moving it to Repository is
counter-optimal in terms of who calls what: Some branches will not allow
setting the revision-history at all (*cough* svn), others will only
accept a last-revision pointer and have no need to generate the full
history. So for now at least, I'm not inclined to move any code onto
repository until we get another user - at which point triangulation is
easy.

> If not, would it be better as part of BzrBranch or the base-level
> Branch. (I would think it would be best as the base-level Repository, so
> any repo which implements get_revision_graph has an implementation, but
> can fast path it if it makes sense for them).

I may have another tweak to do here soon, if I do I'll move it up to
Branch.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060626/bf305437/attachment.pgp