[RFC] KnitData.read_records_iter() returns records out of order

Robert Collins robertc at robertcollins.net
Mon Jun 26 07:34:24 BST 2006


On Mon, 2006-06-26 at 16:27 +1000, Michael Ellerman wrote:

> I disagree, although that might be clean, it means we end up doing
> work we don't need to. I'd rather push the sorting requirement up the
> stack, so that we delay sorting as long as possible, and some callers
> won't require sorting at all.
> 
> So we document the fact that readv() may return records out of order,
> and so on up the stack. We can write an OutOfOrderLocalTransport that
> returns everything in random orders for testing.

Performance wise, its quite important to be doing ordered reads through
the underlying file. This is at odds with pushing the sort order up the
stack.

Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060626/2674704d/attachment.pgp 


More information about the bazaar mailing list