[MERGE] log performance

[Robert Widhopf-Fenk]

On Friday, June 23, 2006 at 16:20:51, Aaron Bentley wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Robert Widhopf-Fenk wrote:
> > On Thursday, June 22, 2006 at 22:46:19, Aaron Bentley wrote:
> > If you have time look at the two messages with
> > 
> >   Subject: [PATCH] move lock_read() into "bzr log" 
> > 
> > The extra lock really gives a felt speedup of 2 on remote
> > repos when getting only a few logs.
> 
> There is no way I would consider removing the lock from
> show_log. cmd_log is not the only caller, and acquiring an
> already-held lock is extremely cheap.

No removing is wrong as John pointed out already.

> I don't see any explanation of what taking the lock earlier
> accomplishes.  Are you trying to avoid reading the revision-history
> twice?

Yes that was the point, but it does not speed up the whole
operation so much anymore with your latest changes.

I might be wrong, but isn't the history ready twice over the
network without the lock?  

Cheers Robert