[MERGE] log performance

Aaron Bentley aaron.bentley at utoronto.ca
Fri Jun 23 21:20:51 BST 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Widhopf-Fenk wrote:
> On Thursday, June 22, 2006 at 22:46:19, Aaron Bentley wrote:
> If you have time look at the two messages with
> 
>   Subject: [PATCH] move lock_read() into "bzr log" 
> 
> The extra lock really gives a felt speedup of 2 on remote
> repos when getting only a few logs.

There is no way I would consider removing the lock from show_log.
cmd_log is not the only caller, and acquiring an already-held lock is
extremely cheap.

I don't see any explanation of what taking the lock earlier
accomplishes.  Are you trying to avoid reading the revision-history twice?

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFEnE0i0F+nu1YWqI0RAmj7AJ0W/ywPo4aPmY9SKjz8X7ILOPh/0gCfcxIL
uhYnaYB6Mvm/XTNhDF/XKzc=
=NCJB
-----END PGP SIGNATURE-----




More information about the bazaar mailing list