[BUG?] Invalid URL join request pulling from John's branch

[Wouter van Heyst]

On Wed, Jun 21, 2006 at 01:02:19PM +1000, Michael Ellerman wrote:
> Hey John,
> 
> I can't pull from your http branch:
> 
> concordia ~/src/bzr/mirrors$ ./trunk/bzr branch http+urllib://bzr.arbash-meinel.com/branches/bzr/http/ jam-http
> bzr: ERROR: Invalid URL join request: ['http+urllib://bzr.arbash-meinel.com/branches/bzr/http', '../../../../../../home/jameinel/bzr/mirrors/bzr/bzr.dev/']: Cannot go above root
> 
> It works with an older branch I have lying around (revno 1414), smells
> like a URL encoding bug?

urlutils.join in branch.get_parent() fails. 

The parent branch should in this case be reachable as
http://bzr.arbash-meinel.com/mirrors/bzr/bzr.dev, so I'm not sure why
the relative path is so different. 

So in the case this is a valid path, which would result in a
publically non-reachable parent, what should we do? I'm inclined to just
return other when the join would go above the root.


Wouter van Heyst