[plugin] binary sys.stdout/err on win32

[John Arbash Meinel]

Aaron Bentley wrote:
> John Arbash Meinel wrote:
>>> This turns it on a little bit later than I would like, but I think it is
>>> a reasonable compromise.
>>> My concern is that all the developers will turn it on, but because the
>>> default is off, we won't really be using it the way a new user would.
> 
> I'd like to force it on for "bundle".  I'm not sure whether bundles will
> display reasonably in console windows, though.

I did check, and '\n' formated text displays just fine in 'cmd.exe'. It
is only 'notepad' that gets it wrong.

> 
> I'm not entirely comfortable with reusing "exact" to indicate "binary".
>  It reminds me of the old Transport UI where 'rb' produced a bytstring
> file and 'r' produced a Unicode file.
> 
> Perhaps 'exact-binary' makes sense.  Or maybe just making bundles
> indicate newline type.

Yeah, I had been thinking about it. And I think just having a separate
function that can be called, like 'self.ensure_binary_output()'. Then
'bundle' could always call it, and 'diff' could call it if the
'--strict' flag is sent. I want --strict anyway, so that we can switch
to utf-8 filenames, rather than local 'replace' style filenames.

> 
>>> As far as Martin's suggestion to also do sys.stdin. I would consider it
>>> if bzr actually ever read from stdin.
> 
> I think it's reasonable to support '-' for reading bundles from stdin.
> 
> Aaron

Are you thinking of a new command, or are you thinking 'bzr merge -'.

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060619/44e3d1b3/attachment.pgp