[MERGE] lsprof branch

John Arbash Meinel john at arbash-meinel.com
Mon Jun 19 00:02:02 BST 2006


Robey Pointer wrote:
> With all the profiling and performance work being done, I thought it'd
> be a good time to point out the lsprof branch again.  Since I haven't
> needed to change it in a long time (except to merge bzr.dev), it'd be
> nice to have it merged and not have to keep it up to date anymore.
> 
> The branch lives here:
>     http://www.lag.net/~robey/code/bzr.dev.lsprof
> 
> robey

Can you give us a reminder about what the major changes are? I see
something about doing threaded profiling, and something about Calltree
and various filtering.

Is this only to add support for viewing the profile output in KCacheGrind?

You import 'logging' at the top, but you never actually use it. Why?

Why all the threading calls. At least at present bzrlib is very single
threaded. (The only threads I know of are the server threads in the test
suite).

You add a parameter 'threads' to Stats, but you call it with an empty
dictionary.

If this helps something, I would be happy to merge it. But it has been
long enough since it was discussed it needs a little bit of text so we
understand what is going on.

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060618/00110385/attachment.pgp 


More information about the bazaar mailing list