[merge] Profile import time

John Arbash Meinel john at arbash-meinel.com
Sun Jun 18 06:00:38 BST 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
> John Arbash Meinel wrote:
>>> Attached is an updated version of my 'profile-imports' that I mentioned
>>> earlier. Martin was only so-so on it saying "If you feel it is important".
> 
> This looks good.  +1 overall.  It might be nicer to record this data by
> building up a table and munging it afterward.  Then we could calculate
> inline time, too.
> 
> Also, column 2 looks redundant with column three.  Do we need both?

I decided to remove the second column until we actually need it.

I now build up the import/regex compile stack while running, and then at
the end we print out the sorted stack. Sorting is optional in case you
actually want to see the order everything occurs in. But the default is
to move the expensive things up the list.

I'm also defaulting to hiding things that take < 0.1ms to import. This
means that fixing an import in one place might make it show up in
another place (since it is still being imported), but it helps make it
clear what is going on. (Everytime a module is imported after the first,
it takes 0.0ms which clutters the profile)

Attached is the new output, I'm pretty happy with it.

I'm only attaching the diff, since the bundle has quite a bit of cruft now.

If you give me another +1 I'll merge it.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFElN31JdeBCYSNAAMRAri7AJ9OsOpSxGed67cY0qdStKw4ds6iGQCffIxh
cKCBfo1AlCkUBNc6mO/1WKY=
=Vh3M
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ,,import-root.txt
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20060618/a8741aaf/attachment.txt 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: profile-imports.patch
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20060618/a8741aaf/attachment.diff 


More information about the bazaar mailing list