[RFC][MERGE] refactoring of info tests

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> On Fri, 2006-06-16 at 01:58 +1000, Robert Collins wrote:
>> This is a partial refactoring of the info tests, prompted when I
>> realised they all broke with a new tree format... 
>>
>> It preserves the explicit declaration of what is wanted, but tries to
>> make that more 'I want a light checkout output' rather than 'this exact
>> sequence of bytes', so the tests require less adjustment while still
>> being valid.
> 
> John noted that I had noise in here from the format change that prompted
> the work - herewith a patch with that removed.
> 
> Rob
> 

Odd that you named your file '.py'
(Have I ever mentioned that I would really like it if a mail client
supported syntax highlighted diffs? Especially if it could still syntax
highlight with the > prefix so I can read it while responding)

v- Why are these hunks still present when there is no actual change?

> @@ -676,7 +613,7 @@
>  
>  Format:
>         control: Meta directory format 1
>    working tree: Working tree format 3
>          branch: Branch format 5
>      repository: %s
>  
> @@ -716,7 +653,7 @@
>  
>  Format:
>         control: Meta directory format 1
>    working tree: Working tree format 3
>          branch: Branch format 5
>      repository: %s
>  

Anyway, refactoring the tests to use a helper function parameterized on
what should be in there == +1.

The patch itself is pretty hard to read, but I didn't see anything
terrible, and if it passes self tests, +1 from me.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEkuPTJdeBCYSNAAMRAjBOAJ0f1sSf0jDT6OWRKO5uNCBUs8xj8wCeNfre
3VdlElf+ssFnGUhxQ1vf/48=
=EudP
-----END PGP SIGNATURE-----