[MERGE] trees - add get_parent_ids

Aaron Bentley aaron.bentley at utoronto.ca
Fri Jun 16 15:01:10 BST 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> This patch adds a get_parent_ids() call to all our tree objects (at
> least, I think to all of them ;)).
> 
> This call returns:
> [] for a tree with unknown parents

I think this should be something other than the empty list.  Possibly an
exception.

> ['null:'] for a tree descending from null:

e.g. revno 1, right?

> [revid, ...] in general.
> 
> EmptyTree descends from ['null:'].

EINFINITELOOP.  EmptyTree doesn't descend from 'null:', it *is* 'null:'.
 EmptyTree should return [], because 'null:' does not descend from 'null:'.

> RevisionTree mirrors the revision graph.
> WorkingTree provides the union of last_revision and pending merges.

These are fine, though.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFEkrmm0F+nu1YWqI0RAhh7AJ96rtEifsebbreTKDOWQ/dHlHH/JwCeM2yA
r6eDhj524hnv/z+Pt9j2+a8=
=Thyr
-----END PGP SIGNATURE-----




More information about the bazaar mailing list