Using fixed variables probably doesn't help
John Arbash Meinel
john at arbash-meinel.com
Fri Jun 16 14:53:02 BST 2006
-----BEGIN PGP SIGNED MESSAGE-----
Robert Collins wrote:
> On Thu, 2006-06-15 at 20:57 -0500, John Arbash Meinel wrote:
>> Anyway, I'm guessing that we shouldn't spend any time trying to pass
>> around object references rather than just using 'file' and 'directory'.
>> The only thing we may want to start doing is calling 'intern()' for
>> stuff we read from a file.
> I think we should use static objects rather than strings because its
> more clear - I'm echoing spivs statement here about static analysis too.
> I agree that we dont need to try to optimise the actual comparisons
I'm fine with the clarity aspect. But if you want to do that, we
probably should promote 'osutils._directory_kind' to being public, and
add file_kind and symlink_kind. I don't think we need ones for stuff
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v18.104.22.168 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the bazaar