Sftp type error #49363

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robey Pointer wrote:
> 

...

>>
>> I personally don't like the look of the '_' variable names, though I
>> understand it is because you are ignoring the return value.
>> Perhaps 'dummy', though I wouldn't block on it.
> 
> I'm agnostic and happy to change them to 'dummy'.  I picked up the '_'
> habit from some other python code I saw once.  Ammended patch attached.
> 
> 
>> Is select.select() portable across platforms?
>> Any reason not to use asyncore instead?
> 
> It should be (on sockets only).  Asyncore would probably work too.  The
> point of the select() here is not to poll multiple sockets, but to do an
> equivalent to socket.accept(timeout).  Gawd, I've written this kind of
> code so many times that I feel older just looking at it again.  Anyway,
> the timeout is so that we can simultaneously scan for an incoming
> accept() *and* the stop_event.
> 
> robey

It is indeed fixed. +1 overall. This makes the SFTP tests *much* faster.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEkgdvJdeBCYSNAAMRAnJZAJ9tIVRPGGAUCTyd+YnNn5s/zFvB3QCfc70P
pcn0QdElqnAXhYawLNIq/PA=
=7Fcl
-----END PGP SIGNATURE-----