[win32][BUG] url to filesystem???

Martin Pool mbp at canonical.com
Fri Jun 16 01:08:20 BST 2006


On 15/06/2006, at 12:09 PM, John Arbash Meinel wrote:
>

> I fixed this up by pulling the win32 specific behavior into a separate
> function, which can be separately tested. Having a 'platform=' isn't
> quite right, because some things are selected at import time rather  
> than
> at runtime.
>
> This isn't perfect either, since it doesn't guarantee that the upper
> level function returns the right thing, but there is only so deep that
> you can test.
>
> Also, some things don't work right without being on the platform.
> ntpath.abspath() actually is faked on non-win32 platforms.

This looks good, thanks.  As you say there's always a limit to what  
can reasonably be tested but I think this gets us a bit further in  
the right direction.  So +1 from me.
-- 
Martin







More information about the bazaar mailing list