CommitBuilder tests fail with nested trees

[Jelmer Vernooij]

On Thu, 2006-06-15 at 18:29 -0400, Aaron Bentley wrote:
> Jelmer Vernooij wrote:
> >      def test_finish_inventory(self):
> >          tree = self.make_branch_and_tree(".")
> >          builder = tree.branch.get_commit_builder([])
> > +        builder.set_root_id(None)
> >          builder.finish_inventory()
> It might be nice to make None the default, and just do
> builder.set_root_id().  The rationale being that you're not actually
> setting it to None.
That's a good idea. Fixed in the attached bundle as well as the other
issues you pointed out.

Will also be available shortly from
http://people.samba.org/bzr/jelmer/bzr/nested-trees

Cheers,

Jelmer

-- 
Jelmer Vernooij <jelmer at samba.org> - http://samba.org/~jelmer/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nested-tree-root-ids2.bundle.diff
Type: text/x-patch
Size: 0 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060616/c7b1e664/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060616/c7b1e664/attachment.pgp