CommitBuilder tests fail with nested trees

Jelmer Vernooij jelmer at
Thu Jun 15 22:08:56 BST 2006

On Thu, 2006-06-15 at 08:02 -0400, Aaron Bentley wrote:
> I've updated my nested trees branch to the latest, and
> everything passes except the CommitBuilder tests.  This is because they
> call CommitBuilder.finish_inventory before the root ID has been set.
> I think it makes sense to require the root ID to be set explicitly.  If
> we supply a default when there's no root ID, people may misuse the API
> by accident, and get the wrong root ID.
> Where should this root ID setting be done?
I think it would make sense to require that
CommitBuilder.record_entry_contents() always gets called for the root
node before CommitBuilder.finish_inventory() gets called.

Attached bundle does this (now passes all tests).

Please comment.


Jelmer Vernooij <jelmer at> -
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nested-tree-root-ids.bundle.diff
Type: text/x-patch
Size: 4803 bytes
Desc: not available
Url : 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : 

More information about the bazaar mailing list