Sftp type error #49363

[Robey Pointer]

On 12 Jun 2006, at 7:55, John Arbash Meinel wrote:

> I just committed the attached patch to fix bug 49363, it just changes
> %d=>%s so that the ConnectionError gets raised properly.
>
> I also added BogusURL support to the sftp server. I originally thought
> that this would flush out the problem. But it doesn't really,  
> because we
> use a different connection method for running the test suite (we  
> connect
>  using a loopback socket, rather than actually doing the full
> handshaking, since that added a lot of time to all the tests).
>
> After adding the bogus_url, it seems we are encountering our timeout
> issues again, since the HTTP tests take 2ms, and the SFTP tests  
> take 5002ms.
>
> What is weird is that in the past, it would raise TestSkipped, which
> caused the test to finish, reporting that it took almost no time, but
> then the test suite would hang waiting for the timeout. Now that it is
> actually running the tests, it shows the timeout when it actually  
> occurs
> as part of the test.


I think I accidentally fixed the 5-second delay with my patch to let  
the stub sftp server handle multiple connections per test.  I  
attached it to a bug on launchpad a few weeks ago, but I can't look  
it up right now so I'll attach the patch here too.

The timing on the tests is pretty random, but when I watch 'selftest  
SFTP', without the patch the SKIP stays up for several seconds.  With  
the patch, it skips past quickly.

robey



-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: listener-patch.txt
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20060612/8538889c/attachment.txt