[MERGE] hide old diffs in bundles

John Arbash Meinel john at arbash-meinel.com
Mon Jun 12 18:25:14 BST 2006


Aaron Bentley wrote:
> John Arbash Meinel wrote:
>>> Aaron Bentley wrote:
>>>
>>>> Anyone object to this?
>>>>
>>>
>>> Looking at your bundle which uses it... (show_log with get_revisions)
>>>
>>> It does make the overall patch easier to review, since it is obvious
>>> when you hit old revisions.
>>>
>>> It is a little bit ugly, though, so I'm probably only +0.5 on it.
> 
> What's ugly?  The output or the code?
> 
> It seem expedient to me, because it fixes problems we're having right
> now with the bundles people submit.  You wanted to work on bundle code,
> so I'm laying off making major changes-- this is the smallest change I
> can think of that addresses the problem.
> 
> Aaron

the output is ugly. The code is fine.
I can't think of anything better. And it is a reasonable stopgap.

If Robert or Martin say "I prefer reviewing bundles in this format", you
have my +1.

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060612/1938f2de/attachment.pgp 


More information about the bazaar mailing list