Sftp type error #49363

John Arbash Meinel john at arbash-meinel.com
Mon Jun 12 15:55:45 BST 2006

I just committed the attached patch to fix bug 49363, it just changes
%d=>%s so that the ConnectionError gets raised properly.

I also added BogusURL support to the sftp server. I originally thought
that this would flush out the problem. But it doesn't really, because we
use a different connection method for running the test suite (we connect
 using a loopback socket, rather than actually doing the full
handshaking, since that added a lot of time to all the tests).

After adding the bogus_url, it seems we are encountering our timeout
issues again, since the HTTP tests take 2ms, and the SFTP tests take 5002ms.

What is weird is that in the past, it would raise TestSkipped, which
caused the test to finish, reporting that it took almost no time, but
then the test suite would hang waiting for the timeout. Now that it is
actually running the tests, it shows the timeout when it actually occurs
as part of the test.

Seeking a +1 to merge.


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: sftp-type-error-49363.diff
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20060612/20ccfd32/attachment.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060612/20ccfd32/attachment.pgp 

More information about the bazaar mailing list