[BUNDLE] Fix typos

Aaron Bentley aaron.bentley at utoronto.ca
Mon Jun 12 02:32:56 BST 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jelmer Vernooij wrote:
> Hi,
> 
> The attached bundle fixes a couple of typos in the bzr source code found
> by simply running 'aspell' on the Python files.

Thanks for doing this.  How'd you avoid false positives from variable
names, etc?

It would be amusing to combine aspell output with annotate, to determine
bzr's best and worst spellers.

> -        This could memoise the branch, but if thats done
> +        This could memorize the branch, but if thats done

This isn't a typo.  See here:
http://en.wikipedia.org/wiki/Memoization

Also, should be "that's done"

>          it must be revalidated on each new lock.
> -        So for now we just dont memoise it.
> +        So for now we just dont memorize it.
>          # RBC 20060304 review this decision.
>          """

Again.  And "don't"

>  class Graph(object):
> -    """A graph object which can memoise and cache results for performance."""
> +    """A graph object which can memorize and cache results for performance."""

Again.
> -        # optimisable if needed by memoising the _ghosts set.
> +        # optimisable if needed by memorizing the _ghosts set.

Again.

> === modified file bzrlib/osutils.py
> --- bzrlib/osutils.py	
> +++ bzrlib/osutils.py	
> @@ -553,7 +553,7 @@
>  
>  
>  ## TODO: We could later have path objects that remember their list
> -## decomposition (might be too tricksy though.)
> +## decomposition (might be too tricky though.)

"Tricksy" looks like a deliberate reference to Gollum's speech-patterns.

> -        This detect inconsistences based on the self.thorough value:
> +        This detect inconsistencies based on the self.thorough value:

Actually, it should be "This detects"...

> -        We dont test for the stores being of specific types becase that
> +        We dont test for the stores being of specific types because that

Actually, this should be "We don't test"...

> @@ -1592,7 +1592,7 @@
>          if basis is not None:
>              # copy the basis in, then fetch remaining data.
>              basis.copy_content_into(self.target, revision_id)
> -            # the basis copy_content_into could misset this.
> +            # the basis copy_content_into could missed this.

"Misset" looks deliberate, though it could be spelled "mis-set" or maybe
"miss-set".

> -        We dont test for the stores being of specific types becase that
> +        We dont test for the stores being of specific types because that

Additionally, it should be "don't".

> === modified file bzrlib/transform.py
> --- bzrlib/transform.py	
> +++ bzrlib/transform.py	
> @@ -891,7 +891,7 @@
>  
>  
>  class FinalPaths(object):
> -    """Make path calculation cheap by memoizing paths.
> +    """Make path calculation cheap by memorizing paths.

Again with the memoization.  US form, this time.

> === modified file bzrlib/tree.py
> --- bzrlib/tree.py	
> +++ bzrlib/tree.py	
> @@ -150,6 +150,7 @@
>      def get_file_lines(self, file_id):
>          ie = self._inventory[file_id]
>          weave = self.get_weave(file_id)
> +        assert ie.revision
>          return weave.get_lines(ie.revision)
>  
>      def get_file_text(self, file_id):
> 

This doesn't look like a spelling fix :-)

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEjMRH0F+nu1YWqI0RAmVFAJ9NlijPA2jV5wqPlX3flHSlXO5ougCfZTZr
Iv3mjq2/etAxAnsj5ADrMCQ=
=Hvfj
-----END PGP SIGNATURE-----




More information about the bazaar mailing list