[BUNDLE] let PyCurl transport read multiple ranges.
John Arbash Meinel
john at arbash-meinel.com
Thu Jun 8 15:37:27 BST 2006
Johan Rydberg wrote:
> John Arbash Meinel <john at arbash-meinel.com> writes:
>> If you are doing it correctly, you shouldn't need a caching DNS server
>> for pyCurl objects. They cache their own requests (something like 60s).
>> Could you test that to make sure?
> You are correct. It does not make any difference if I do not use the
> caching DNS server. It must have been some fluke when I did my
> earlier tests then.
>> I would probably avoid "__readv" because the __ cannot be overridden or
>> accessed easily in the child.
> Made it into a nested function instead.
>> I would also not create the object as Curl, perhaps 'CurlWrapper' so
>> that it isn't confusing what type of object you have.
>> You changed the code to unset the 'pycurl.FOLLOWLOCATION' flag, which is
>> a functional change. I'm not sure how we should handle this.
> My mistake. Corrected.
>> Otherwise the performance effect is very nice. Thanks for your work.
> It's Michaels work, I just polished it a bit.
+1 from me.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 249 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060608/1b763943/attachment.pgp
More information about the bazaar