[MERGE] support non '.bzr' control directories better.

Martin Pool mbp at canonical.com
Wed Jun 7 18:36:23 BST 2006


On  8 Jun 2006, Robert Collins <robertc at robertcollins.net> wrote:

> > > +
> > >      def open(self, transport, _found=False):
> > >          """Return an instance of this format for the dir transport points at.
> > 
> > I think there are too many layers here: do we really need sets of sets?
> > I understand it can optimize probing a little (read .bzr/branch-format
> > once, then compare to various strings) but we can deal with that later.
> 
> Well, on remote connections reading these files is extremely expensive.
> I'm sure we *can* deal with it later, I'm not sure we want to do so.

OK, go with what you had, but please add some kind of comment about why
there's double-indirection.

> Can I add this as a TODO or would you like it done pre-merge.

It can be separate.

-- 
Martin




More information about the bazaar mailing list