[MERGE] Use slots consistently in InventoryEntry hierarchy -- update

Martin Pool mbp at canonical.com
Wed Jun 7 14:43:28 BST 2006


On  1 Jun 2006, Jan Hudec <bulb at ucw.cz> wrote:

> Ok. I have tried to update the patch to address this and Aaron's concerns.
> The 'kind' is now a normal class attribute and so are all the other
> attributes specific to some InventoryEntry subclass. So the serializers can
> safely read all of them and get None for the unapplicable ones, so they are
> kind-agnostic again (I actually reverted them to the old code except
> replacing the 'something != None' constructs with proer 'something is not
> None'.
> 
> Please review. The original version got +1, -0, +1. I am attaching both the
> complete diff from mainline (ok, 3 revisions back at this point) and a diff
> of just the updates. Please use
> http://drak.ucw.cz/~bulb/bzr/bzr/inventory-slots for merging.

+1, ok with me.  Thanks.

-- 
Martin




More information about the bazaar mailing list