[MERGE] support non '.bzr' control directories better.

[Jan Hudec]

On Fri, Jun 02, 2006 at 09:39:17 +0100, John A Meinel wrote:
> Jan Hudec wrote:
> > On Thu, Jun 01, 2006 at 16:16:39 +1000, Robert Collins wrote:
> >> This should be useful for jelmer's SVN work, and was needed for my hg
> >> plugin.
> >>
> >> Branch is at
> >> http://people.ubuntu.com/~robertc/baz2.0/non-bzr-control-dirs
> > 
> > May I suggest a slight optimization? Most of the time bzr is used with
> > bzr branches and therefore BzrDirFormat would be the one that matches.
> > So it would make sense to explicitely try it first.
> > 
> 
> I think this is reasonable. I have to wonder if using a list rather than
> a set would be a better thing. (So we probe for .bzr, then _bzr, then
> the rest).

If I understood it correctly, it's a set to make sure every format is
registered just once. Now there are two questions:

  - Don't we always know to register it just once? We register it right
    after defining the format and that's only done once. So the
    registration shouldn't be done repeatedly either.

  - Wouldn't just checking it's not already there and then appending it
    to the list be sufficient? The list won't be so long.

-- 
						 Jan 'Bulb' Hudec <bulb at ucw.cz>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060602/d0fc6755/attachment.pgp