[RFC/MERGE] Allow two plugins to register the same command.

Aaron Bentley aaron.bentley at utoronto.ca
Tue May 30 18:28:34 BST 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Michael Ellerman wrote:
> On 5/31/06, Aaron Bentley <aaron.bentley at utoronto.ca> wrote:
>> So, the second one to be registered gets prefixed with the module name?
>>
>> That seems unpredictable to me.

> Well it's unpredictable unless you have numbered names in your
> .bazaar/plugins. ie I have "01_shelf" and "02_bzrtools", so "shelve"
> is always from shelf and "bzrlib-plugins-bzrtools-shelve" is from the
> bzrtools version.

So I'm not sure that we load plugins in a sorted order.  I thought we
just did 'os.list', which isn't always sorted.

Also, AIUI, the directory names are supposed to be 'shelf' and 'bzrtools'.

> The disambiguate/alias idea is interesting, and might be preferable.
> It certainly gives more flexibility, and would work for people who
> don't have control of the plugin directories (possibly on a shared
> install of bzr eg.) I'll think about it.

Agreed.

>> Also, perhaps it's worth allowing all commands to be specified using the
>> module name.
> 
> 
> Just for completeness? Or do you have a use case where that would be
> useful? I can't think of one.

Well, as a way to unambiguously specify a command.  If you're writing
scripts that may be used on various machines, with different sets of
plugins, using the full module command name would ensure that the script
behaved properly on all of them.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFEfIDB0F+nu1YWqI0RAqCYAJ4s8uwQFYFrzsvbVKAZj5gHsIUmgACfYYIz
FduXWbhx4f9d5cEf99anWNY=
=2qYH
-----END PGP SIGNATURE-----




More information about the bazaar mailing list