[MERGE] bzrk "improvements"

Michael Ellerman michael at ellerman.id.au
Tue May 30 16:56:07 BST 2006


Hi David,

You seem to be the latest bzrk maintainer :)

My branch at http://michael.ellerman.id.au/bzr/branches/bzrk/ has two
commits which I think are useful:

Remove the border on the diff window, so that when maximized the scroll
bar sits on the right screen edge and is easier to hit.

=== modified file 'diffwin.py'
--- diffwin.py
+++ diffwin.py
@@ -51,7 +51,7 @@
     def construct(self):
         """Construct the window contents."""
         hbox = gtk.HBox(spacing=6)
-        hbox.set_border_width(12)
+        hbox.set_border_width(0)
         self.add(hbox)
         hbox.show()


Instead of having a "jump to revision" button with a dubious icon, make
the revision name the button instead.

=== modified file 'branchwin.py'
--- branchwin.py
+++ branchwin.py
@@ -345,17 +345,6 @@

             image = gtk.Image()
             image.set_from_stock(
-                gtk.STOCK_JUMP_TO, gtk.ICON_SIZE_SMALL_TOOLBAR)
-            image.show()
-
-            button = gtk.Button()
-            button.add(image)
-            button.connect("clicked", self._go_clicked_cb, parent_id)
-            hbox.pack_start(button, expand=False, fill=True)
-            button.show()
-
-            image = gtk.Image()
-            image.set_from_stock(
                 gtk.STOCK_FIND, gtk.ICON_SIZE_SMALL_TOOLBAR)
             image.show()

@@ -367,10 +356,10 @@
             hbox.pack_start(button, expand=False, fill=True)
             button.show()

-            label = gtk.Label(parent_id)
-            label.set_selectable(True)
-            hbox.pack_start(label, expand=False, fill=True)
-            label.show()
+            button = gtk.Button(parent_id)
+            button.connect("clicked", self._go_clicked_cb, parent_id)
+            hbox.pack_start(button, expand=False, fill=True)
+            button.show()


     def _back_clicked_cb(self, *args):

I've attached a screen shot of the second one so people can see what I
mean.

cheers

-- 
Michael Ellerman
IBM OzLabs

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screenshot.png
Type: image/png
Size: 65015 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060531/8dcb37c3/attachment.png 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060531/8dcb37c3/attachment.pgp 


More information about the bazaar mailing list