cdv test failures

John Arbash Meinel john at arbash-meinel.com
Thu May 25 15:03:49 BST 2006


Robert Collins wrote:
> On Wed, 2006-05-24 at 23:36 -0500, John A Meinel wrote:
>> So it seems like we might need to copy the SequenceMatcher from the
>> old
>> difflib. 
> 
> lets do it. Also, lets send python a bug saying this should be fully and
> cleanly overridable. :)
> 
> Rob

Well, it turns out that their change was to remove the __helper function
which had a recursive definition, and switch to some inline code that
uses a queue.

So I just needed to override get_matching_blocks() rather than
overriding __helper().

Attached is the diff that makes the tests pass on 2.4.3.

It probably is better to override a non-private function anyway, since
that is the stable interface. __helper was probably considered an
implementation detail.

John
=:->

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: override_get_matching.diff
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20060525/34e6ea2a/attachment.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060525/34e6ea2a/attachment.pgp 


More information about the bazaar mailing list