[PATCH] do binary search for -r date:....

Robert Widhopf-Fenk hack at robf.de
Tue May 23 23:05:11 BST 2006


On Monday, May 22, 2006 at 21:27:42, Guillaume Pinot wrote:
> The following message is a courtesy copy of an article that has been
> posted to gmane.comp.version-control.bazaar-ng.general as well.
> 
> Robert Widhopf-Fenk <hack at robf.de> writes:
> 
> > Attached is Guillaumes version against current bzr.dev with
> > added branch.lock_read() and branch.unlock() around the call
> > to bisect.
> 
> Is it needed? If yes, I'll add it in my branch

Without the lock it will read, parse and ???  the revisions
knit and index each time you get a revision for checking
its commit date.  Specifically, I got a firework display of
progress bars which initially made me think I found a bug
where BZR was hanging in an endless loop.

At least this is what it looks like to me and how I
understand Robert Collins answer to my initial message
without actually doing any further debugging. 

On Tuesday, May 23, 2006 at 19:47:37, Martin Pool wrote:
[...]
> Thanks Robert - but note that these should always be paired in a
> try/finally block, so that we unlock the branch even if e.g. the
> user hits C-c during the search.

As I could have seen by the use of lock_read at other places
in the code ... I still try to leaning Python by reading and
hacking a bit on BZR and using it for my pet projects.

And so far BZR rocks on Linux, Windows and my USB stick ;-)
Recently I had a hard time recalling the right syntax for
tla/baz commands ... 

Robert




More information about the bazaar mailing list