[PATCH] do binary search for -r date:....

Martin Pool mbp at canonical.com
Tue May 23 10:47:37 BST 2006


On 22 May 2006, Guillaume Pinot <guillaume.pinot at tremplin-utc.net> wrote:
> The following message is a courtesy copy of an article
> that has been posted to gmane.comp.version-control.bazaar-ng.general as well.
> 
> Robert Widhopf-Fenk <hack at robf.de> writes:
> 
> > Attached is Guillaumes version against current bzr.dev with
> > added branch.lock_read() and branch.unlock() around the call
> > to bisect.

Thanks Robert - but note that these should always be paired in a
try/finally block, so that we unlock the branch even if e.g. the user
hits C-c during the search.

> Is it needed? If yes, I'll add it in my branch
> 
> > I was not aware of bisect and Guillaumes and your work on
> > this ... ;-/
> 
> no troubles ;-)
> 
> I'm waiting for the merge (Martin?).

Thanks, merged now.

-- 
Martin Pool




More information about the bazaar mailing list