Transport connection caches must go.

[John Arbash Meinel]

Robert Collins wrote:
> On Mon, 2006-05-22 at 08:32 -0500, John Arbash Meinel wrote:
>> Michael Ellerman wrote:
> 
> 
>> That is the way the current code is. But both ftp and sftp cache their
>> connections. It would seem reasonable that HTTP could do the same thing.
> 
> please no. The SFTP connection cache is an ongoing burden and I'm about
> +5 for any patch that removes it with extreme prejuidice. 
> 
> There was a previous thread on this a few weeks back, but the title
> wasn't changed unfortunately.
> 
> -Rob

What would you prefer? I think we should have some sort of keep-alive.

One could argue for a single BzrDir connection. But I think it would be
nice if doing "bzr branch sftp://foo/one sftp://foo/two" didn't require
you to login twice. And remembering the connection at the Transport
level seems the right place to do it.

Right now the sftp cache is just a weakref dictionary, so it should
expire when nobody is using it anyway.

John
=:->


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060522/6b0b52a1/attachment.pgp