[merge] FTP now has and passes regression tests

Martin Pool mbp at canonical.com
Mon May 22 04:17:51 BST 2006

On 18 May 2006, John A Meinel <john at arbash-meinel.com> wrote:
> -from bzrlib.transport import Transport
> -from bzrlib.errors import (TransportNotPossible, TransportError,
> -                           NoSuchFile, FileExists, DirectoryNotEmpty)
> +try:
> +    import medusa
> +    import medusa.filesys
> +    import medusa.ftp_server
> +except ImportError:
> +    _have_medusa = False
> +else:
> +    _have_medusa = True

This will import medusa and asyncore every time the ftp module is loaded, which 
seems a bit unnecessary.

More generally it seems a bit wasteful to define the server code in
the transport modules and so load it every time when we almost always
only want the client.  But you don't need to change that now.

+1 from me.

More information about the bazaar mailing list