[MERGE][RFC] further add performance improvements

[John Arbash Meinel]

Robert Collins wrote:
> here is a draft patch for another 100% improvement over what Martin and
> I did this afternoon.
> 
> This patch refactors smart_add_tree to use the parent inventory entry
> rather than looking up the path at every step along the tree. This gives
> me a profiled performance of 5s for me on a 10K file tree, down from 10s
> with the work we did earlier today, or 25s before tuning at all.
> 
> Its a little ugly because it has to allow the dry run mode to carry on
> working, which is actually broken I think anyhow. Perhaps a 'dry run'
> flag is actually better here? (That could trigger a
> tree._read_inventory() rather than a write_inventory, for instance).
> This would mean that the callbacks to add could always add, which means
> we'd be able to get at the tree information more simply because the
> parent would be guaranteed once we moved out of the user supplied files.
> 
> Rob
> 

I think we could have 'add' always add the files to the inventory. We
just don't have to write the inventory to the disk when we are done.

John
=:->


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060519/c81b83f8/attachment.pgp